txn2/kubefwd

This release focuses on MCP tool response, code quality improvements, test reliability, and bug fixes identified by GitHub's security scorecard and code quality analysis tools.

Bug Fixes

MCP Tool Response Format

• Fixed all 24 MCP tool handlers to return complete JSON data instead of text summaries
• AI clients now receive full structured data when using MCP tools like list_services, add_namespace, etc.
• Resolves issue where add_namespace reported "Discovered 0 services" despite successful forwarding

SLSA Provenance Generation

• Fixed artifact hash generation in release workflow
• Previous implementation failed silently when certain file types (e.g., .zip) didn't exist
• Now uses find command to reliably locate all artifacts before hashing

Test Improvements

Eliminated Flaky Tests

• Replaced time.Sleep patterns with proper synchronization using waitForCondition helper
• Affected tests in pkg/fwdsvcregistry now poll for conditions instead of arbitrary delays

Race Condition Fixes

• Replaced sync.Once with mutex-protected bool in pkg/fwdapi/manager.go and pkg/fwdapi/logbuffer.go
• Tests can now properly reset and restore global state without race conditions

Code Quality

• Replaced confusing string(rune('0'+i)) patterns with fmt.Sprintf for clarity
• Fixed invalid port number (99999 → 65535) in network error test
• Replaced custom contains helper with strings.Contains
• Improved non-string conversion test to verify actual type assertions

Build/CI Improvements

• Pinned GoReleaser version to ~> v2.13 in both CI and release workflows
• Improved artifact hash generation reliability for SLSA provenance

Full Changelog

Changed Files

• .github/workflows/ci.yml - Pin GoReleaser version
• .github/workflows/release.yml - Pin GoReleaser version, fix hash generation
• pkg/fwdapi/logbuffer.go - Replace sync.Once with mutex pattern
• pkg/fwdapi/logbuffer_test.go - Improve test reliability and clarity
• pkg/fwdapi/manager.go - Replace sync.Once with mutex pattern
• pkg/fwdapi/manager_test.go - Update for new initialization pattern
• pkg/fwdmcp/httpclient_test.go - Fix invalid port number
• pkg/fwdmcp/tools.go - Return nil CallToolResult for proper JSON responses
• pkg/fwdmcp/tools_test.go - Update tests for new handler behavior
• pkg/fwdmetrics/httpsniff_test.go - Replace confusing string expressions
• pkg/fwdns/manager_test.go - Use strings.Contains
• pkg/fwdsvcregistry/fwdsvcregistry_test.go - Add waitForCondition, eliminate time.Sleep

Changelog

• 0271289c76dd59e49abe8b15784f20dc4779bbbd MCP Registry Readiness (#341)
• 1f7def59878ef59ae720871e4ad67e8c3e12a552 MCP and Test Quality Improvements (#342)